Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new snapshot directory config #305

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Add a new snapshot directory config #305

merged 4 commits into from
Jun 30, 2023

Conversation

yzang2019
Copy link
Collaborator

@yzang2019 yzang2019 commented Jun 29, 2023

Describe your changes and provide context

This change add a new config snapshot-directory in app.toml to override default directory for storing state sync snapshot.

Testing performed to validate your change

Tests are covered in sei-protocol/sei-chain#944

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #305 (dc21be6) into main (58083f6) will decrease coverage by 0.02%.
The diff coverage is 6.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
- Coverage   55.37%   55.36%   -0.02%     
==========================================
  Files         620      620              
  Lines       51599    51611      +12     
==========================================
+ Hits        28571    28572       +1     
- Misses      20947    20958      +11     
  Partials     2081     2081              
Impacted Files Coverage Δ
baseapp/baseapp.go 72.32% <ø> (ø)
baseapp/options.go 54.36% <0.00%> (-2.29%) ⬇️
server/config/toml.go 17.85% <ø> (ø)
server/start.go 21.54% <ø> (ø)
simapp/simd/cmd/root.go 68.00% <0.00%> (-1.11%) ⬇️
server/config/config.go 37.08% <50.00%> (+0.17%) ⬆️

@yzang2019 yzang2019 merged commit 24b93d5 into main Jun 30, 2023
@yzang2019 yzang2019 deleted the yzang/SEI-4777 branch June 30, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants